Skip to content

Conversation

@folkertdev
Copy link
Contributor

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2025

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

@rustbot rustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 17, 2025

📌 Commit 96c6427 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
bors added a commit that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests

Successful merges:

 - #148505 (add larger test for `proc_macro` `FromStr` implementations)
 - #148752 (Constify `ManuallyDrop::take`)
 - #148757 (Constify `mem::take`)
 - #148855 (Error if an autodiff user does not set lto=fat)
 - #148912 (add note to `lines` docs about empty str behavior)
 - #148958 (Run codegen tests on a 32-bit target in PR CI)
 - #148994 (Abi compatibility test cleanup)
 - #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
 - #149004 (compiletest: Avoid race condition in file deletion)
 - #149008 (triagebot: remove jsha from notifications for rustdoc HTML)
 - #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b979e1e into rust-lang:main Nov 17, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 17, 2025
rust-timer added a commit that referenced this pull request Nov 17, 2025
Rollup merge of #148994 - folkertdev:abi-compatibility-cleanup, r=jieyouxu

Abi compatibility test cleanup

r? `@jieyouxu`

- moves `NonNull` (and some friends) into `minicore.rs` so it can be re-used.
- tests the abi compatibility of a couple more targets. It's useful to have a comprehensive overview of all ABIs that rust has some amount of support for, e.g. testing for c-variadic or guaranteed tail calls (cc #148748)
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations)
 - rust-lang/rust#148752 (Constify `ManuallyDrop::take`)
 - rust-lang/rust#148757 (Constify `mem::take`)
 - rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat)
 - rust-lang/rust#148912 (add note to `lines` docs about empty str behavior)
 - rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI)
 - rust-lang/rust#148994 (Abi compatibility test cleanup)
 - rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
 - rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion)
 - rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
 - rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants